Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10317] Email Users For Org Claiming Domain #5094

Merged
merged 57 commits into from
Dec 5, 2024

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Nov 27, 2024

🎟️ Tracking

PM-10317

📔 Objective

This will send out emails to users when an org claims the domain they belong to.

📸 Screenshots

User Notification
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

jrmccannon and others added 30 commits November 7, 2024 15:50
# Conflicts:
#	src/Api/AdminConsole/Models/Response/Organizations/CommandResult.cs
#	src/Core/AdminConsole/OrganizationFeatures/Policies/PolicyValidators/SingleOrgPolicyValidator.cs
…evokeNonCompliantOrganizationUserCommand.cs

Co-authored-by: Rui Tomé <[email protected]>
…ation. Adding unknown type to event system user. Adding optional parameter to SaveAsync in policy service in order to pass in event system user.
Copy link
Contributor

github-actions bot commented Nov 27, 2024

Logo
Checkmarx One – Scan Summary & Detailsbf0d2af6-f046-49d9-b474-f3e3463dda78

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 240 Attack Vector
MEDIUM CSRF /src/Api/Auth/Controllers/TwoFactorController.cs: 406 Attack Vector
LOW Heap_Inspection /src/Core/Billing/Licenses/LicenseConstants.cs: 33 Attack Vector
LOW Heap_Inspection /src/Core/Billing/Licenses/LicenseConstants.cs: 27 Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/DomainClaimedByOrganization.html.hbs: 5 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 68
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 106
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 238
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 362
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 89
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 159
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 46
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 65
MEDIUM Privacy_Violation /src/Api/Auth/Models/Request/Accounts/SetPasswordRequestModel.cs: 28
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 922
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 381
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 261

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 15 lines in your changes missing coverage. Please review.

Project coverage is 42.91%. Comparing base (04cf513) to head (0b2dfc2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../Services/Implementations/HandlebarsMailService.cs 0.00% 12 Missing ⚠️
...nizationDomains/VerifyOrganizationDomainCommand.cs 95.00% 0 Missing and 1 partial ⚠️
...els/Mail/ClaimedDomainUserNotificationViewModel.cs 0.00% 1 Missing ⚠️
...re/Services/NoopImplementations/NoopMailService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5094   +/-   ##
=======================================
  Coverage   42.91%   42.91%           
=======================================
  Files        1429     1431    +2     
  Lines       65329    65359   +30     
  Branches     5987     5988    +1     
=======================================
+ Hits        28037    28052   +15     
- Misses      36046    36060   +14     
- Partials     1246     1247    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BTreston
BTreston previously approved these changes Dec 2, 2024
@jrmccannon jrmccannon removed the request for review from a team December 3, 2024 17:03
…fied

# Conflicts:
#	src/Core/AdminConsole/OrganizationFeatures/OrganizationDomains/VerifyOrganizationDomainCommand.cs
@r-tome r-tome merged commit f471fff into main Dec 5, 2024
52 checks passed
@r-tome r-tome deleted the ac/jmccannon/pm-10317-email-user-domain-verified branch December 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants